diff --git a/composer.json b/composer.json index a414985..381d883 100644 --- a/composer.json +++ b/composer.json @@ -18,7 +18,7 @@ "php": ">=5.3.1" }, "require-dev": { - "phpunit/phpunit": "3.7.*", + "phpunit/phpunit": "4.1.*", "satooshi/php-coveralls": "dev-master" }, "autoload": { diff --git a/maxmind-db b/maxmind-db index f887fec..f86528a 160000 --- a/maxmind-db +++ b/maxmind-db @@ -1 +1 @@ -Subproject commit f887fec99eabf6d68746e257b894bae854fefc27 +Subproject commit f86528a05b883955a1c696ffe3bfeaa1224703d0 diff --git a/src/GeoIp2/Database/Reader.php b/src/GeoIp2/Database/Reader.php index a08b66a..edcca79 100644 --- a/src/GeoIp2/Database/Reader.php +++ b/src/GeoIp2/Database/Reader.php @@ -125,7 +125,42 @@ class Reader implements ProviderInterface return $this->modelFor('Omni', $ipAddress); } + public function connectionType($ipAddress) + { + return $this->flatModelFor('ConnectionType', $ipAddress); + } + + public function domain($ipAddress) + { + return $this->flatModelFor('Domain', $ipAddress); + } + + public function isp($ipAddress) + { + return $this->flatModelFor('Isp', $ipAddress); + } + private function modelFor($class, $ipAddress) + { + $record = $this->getRecord($ipAddress); + + $record['traits']['ip_address'] = $ipAddress; + $class = "GeoIp2\\Model\\" . $class; + + return new $class($record, $this->locales); + } + + private function flatModelFor($class, $ipAddress) + { + $record = $this->getRecord($ipAddress); + + $record['ip_address'] = $ipAddress; + $class = "GeoIp2\\Model\\" . $class; + + return new $class($record); + } + + private function getRecord($ipAddress) { $record = $this->dbReader->get($ipAddress); if ($record === null) { @@ -133,10 +168,7 @@ class Reader implements ProviderInterface "The address $ipAddress is not in the database." ); } - $record['traits']['ip_address'] = $ipAddress; - $class = "GeoIp2\\Model\\" . $class; - - return new $class($record, $this->locales); + return $record; } /** diff --git a/src/GeoIp2/Model/AbstractModel.php b/src/GeoIp2/Model/AbstractModel.php new file mode 100644 index 0000000..fddf625 --- /dev/null +++ b/src/GeoIp2/Model/AbstractModel.php @@ -0,0 +1,54 @@ +raw = $raw; + } + + /** + * @ignore + */ + protected function get($field) + { + return isset($this->raw[$field]) ? $this->raw[$field] : array(); + } + + /** + * @ignore + */ + public function __get($attr) + { + if ($attr != "instance" && isset($this->$attr)) { + return $this->$attr; + } + + throw new \RuntimeException("Unknown attribute: $attr"); + } + + /** + * @ignore + */ + public function __isset($attr) + { + return $attr != "instance" && isset($this->$attr); + } + + public function jsonSerialize() + { + return $this->raw; + } +} diff --git a/src/GeoIp2/Model/ConnectionType.php b/src/GeoIp2/Model/ConnectionType.php new file mode 100644 index 0000000..ffc6178 --- /dev/null +++ b/src/GeoIp2/Model/ConnectionType.php @@ -0,0 +1,31 @@ +connectionType = $this->get('connection_type'); + $this->ipAddress = $this->get('ip_address'); + } +} diff --git a/src/GeoIp2/Model/Country.php b/src/GeoIp2/Model/Country.php index c3ba143..2fb75a5 100644 --- a/src/GeoIp2/Model/Country.php +++ b/src/GeoIp2/Model/Country.php @@ -3,8 +3,7 @@ namespace GeoIp2\Model; /** - * This class provides a model for the data returned by the GeoIP2 Country - * end point. + * This class provides a model for the data returned by the GeoIP2 Country. * * The only difference between the City, City/ISP/Org, and Omni model * classes is which fields in each record may be populated. See @@ -33,23 +32,22 @@ namespace GeoIp2\Model; * @property \GeoIp2\Record\Traits $traits Data for the traits of the * requested IP address. */ -class Country implements \JsonSerializable +class Country extends AbstractModel { - private $continent; - private $country; - private $locales; - private $maxmind; - private $registeredCountry; - private $representedCountry; - private $traits; - private $raw; + protected $continent; + protected $country; + protected $locales; + protected $maxmind; + protected $registeredCountry; + protected $representedCountry; + protected $traits; /** * @ignore */ public function __construct($raw, $locales = array('en')) { - $this->raw = $raw; + parent::__construct($raw); $this->continent = new \GeoIp2\Record\Continent( $this->get('continent'), @@ -72,37 +70,4 @@ class Country implements \JsonSerializable $this->locales = $locales; } - - /** - * @ignore - */ - protected function get($field) - { - return isset($this->raw[$field]) ? $this->raw[$field] : array(); - } - - /** - * @ignore - */ - public function __get($attr) - { - if ($attr != "instance" && isset($this->$attr)) { - return $this->$attr; - } - - throw new \RuntimeException("Unknown attribute: $attr"); - } - - /** - * @ignore - */ - public function __isset($attr) - { - return $attr != "instance" && isset($this->$attr); - } - - public function jsonSerialize() - { - return $this->raw; - } } diff --git a/src/GeoIp2/Model/Domain.php b/src/GeoIp2/Model/Domain.php new file mode 100644 index 0000000..cd55b04 --- /dev/null +++ b/src/GeoIp2/Model/Domain.php @@ -0,0 +1,31 @@ +domain = $this->get('domain'); + $this->ipAddress = $this->get('ip_address'); + } +} diff --git a/src/GeoIp2/Model/Isp.php b/src/GeoIp2/Model/Isp.php new file mode 100644 index 0000000..30015db --- /dev/null +++ b/src/GeoIp2/Model/Isp.php @@ -0,0 +1,45 @@ +autonomousSystemNumber = $this->get('autonomous_system_number'); + $this->autonomousSystemOrganization = + $this->get('autonomous_system_organization'); + $this->isp = $this->get('isp'); + $this->organization = $this->get('organization'); + + $this->ipAddress = $this->get('ip_address'); + } +} diff --git a/tests/GeoIp2/Test/Database/ReaderTest.php b/tests/GeoIp2/Test/Database/ReaderTest.php index 1b72092..6940e8c 100644 --- a/tests/GeoIp2/Test/Database/ReaderTest.php +++ b/tests/GeoIp2/Test/Database/ReaderTest.php @@ -71,6 +71,46 @@ class ReaderTest extends \PHPUnit_Framework_TestCase $reader->close(); } + public function testConnectionType() + { + $reader = new Reader('maxmind-db/test-data/GeoIP2-Connection-Type-Test.mmdb'); + $ipAddress = '1.0.1.0'; + + $record = $reader->connectionType($ipAddress); + $this->assertEquals('Cable/DSL', $record->connectionType); + $this->assertEquals($ipAddress, $record->ipAddress); + $reader->close(); + } + + public function testDomain() + { + $reader = new Reader('maxmind-db/test-data/GeoIP2-Domain-Test.mmdb'); + + $ipAddress = '1.2.0.0'; + $record = $reader->domain($ipAddress); + $this->assertEquals('maxmind.com', $record->domain); + $this->assertEquals($ipAddress, $record->ipAddress); + $reader->close(); + } + + public function testIsp() + { + $reader = new Reader('maxmind-db/test-data/GeoIP2-ISP-Org-Test.mmdb'); + + $ipAddress = '2001:1700::'; + $record = $reader->isp($ipAddress); + $this->assertEquals(6730, $record->autonomousSystemNumber); + $this->assertEquals( + 'Sunrise Communications AG', + $record->autonomousSystemOrganization + ); + + // XXX - Add org/isp when available + + $this->assertEquals($ipAddress, $record->ipAddress); + $reader->close(); + } + public function checkAllMethods($testCb) { foreach (array('city', 'cityIspOrg', 'country', 'omni') as $method) {