will/GeoIP2-php
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make unit tests check all the methods

Browse Source
This commit is contained in:
Gregory Oschwald 2013-07-16 09:44:30 -07:00
parent b55d42b5cd
commit 630765f924
1 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
tests/GeoIp2/Test/Database/ReaderTest.php
View File

@ -9,8 +9,12 @@ class ReaderTest extends \PHPUnit_Framework_TestCase
public function testDefaultLanguage() public function testDefaultLanguage()
{ {
$reader = new Reader('maxmind-db/test-data/GeoIP2-City-Test.mmdb'); $reader = new Reader('maxmind-db/test-data/GeoIP2-City-Test.mmdb');
$city = $reader->city('81.2.69.160'); $this->checkAllMethods(
$this->assertEquals('London', $city->city->name); function ($method) use (&$reader) {
$record = $reader->$method('81.2.69.160');
$this->assertEquals('United Kingdom', $record->country->name);
}
);
$reader->close(); $reader->close();
} }
@ -20,16 +24,24 @@ class ReaderTest extends \PHPUnit_Framework_TestCase
'maxmind-db/test-data/GeoIP2-City-Test.mmdb', 'maxmind-db/test-data/GeoIP2-City-Test.mmdb',
array('xx', 'ru', 'pt-BR', 'es', 'en') array('xx', 'ru', 'pt-BR', 'es', 'en')
); );
$omni = $reader->omni('81.2.69.160'); $this->checkAllMethods(
$this->assertEquals('Лондон', $omni->city->name); function ($method) use (&$reader) {
$record = $reader->$method('81.2.69.160');
$this->assertEquals('Великобритания', $record->country->name);
}
);
$reader->close(); $reader->close();
} }
public function testHasIpAddress() public function testHasIpAddress()
{ {
$reader = new Reader('maxmind-db/test-data/GeoIP2-City-Test.mmdb'); $reader = new Reader('maxmind-db/test-data/GeoIP2-City-Test.mmdb');
$cio = $reader->cityIspOrg('81.2.69.160'); $this->checkAllMethods(
$this->assertEquals('81.2.69.160', $cio->traits->ipAddress); function ($method) use (&$reader) {
$record = $reader->$method('81.2.69.160');
$this->assertEquals('81.2.69.160', $record->traits->ipAddress);
}
);
$reader->close(); $reader->close();
} }
@ -54,4 +66,11 @@ class ReaderTest extends \PHPUnit_Framework_TestCase
$reader->city('invalid'); $reader->city('invalid');
$reader->close(); $reader->close();
} }
public function checkAllMethods($testCb)
{
foreach (array('city', 'cityIspOrg', 'country', 'omni') as $method) {
call_user_func_array($testCb, array($method));
}
}
} }