diff --git a/src/components/ble/SimpleWeatherService.cpp b/src/components/ble/SimpleWeatherService.cpp index 729e9352..9735f2d1 100644 --- a/src/components/ble/SimpleWeatherService.cpp +++ b/src/components/ble/SimpleWeatherService.cpp @@ -19,6 +19,8 @@ #include "SimpleWeatherService.h" #include #include +#include + using namespace Pinetime::Controllers; namespace { @@ -42,8 +44,10 @@ namespace { uint64_t timestamp = static_cast(dataBuffer[2] + (dataBuffer[3] << 8) + (dataBuffer[4] << 16) + (dataBuffer[5] << 24) + ((uint64_t) dataBuffer[6] << 32) + ((uint64_t) dataBuffer[7] << 40) + ((uint64_t) dataBuffer[8] << 48) + ((uint64_t) dataBuffer[9] << 54)); - uint8_t nbDays = dataBuffer[10]; - std::array days; + + std::array days; + const uint8_t nbDaysInBuffer = dataBuffer[10]; + const uint8_t nbDays = std::min(SimpleWeatherService::MaxNbForecastDays, nbDaysInBuffer); for (int i = 0; i < nbDays; i++) { days[i] = SimpleWeatherService::Forecast::Day {dataBuffer[11 + (i * 3)], dataBuffer[12 + (i * 3)], dataBuffer[13 + (i * 3)]}; } diff --git a/src/components/ble/SimpleWeatherService.h b/src/components/ble/SimpleWeatherService.h index 9a023af1..a1625464 100644 --- a/src/components/ble/SimpleWeatherService.h +++ b/src/components/ble/SimpleWeatherService.h @@ -46,6 +46,8 @@ namespace Pinetime { int OnCommand(struct ble_gatt_access_ctxt* ctxt); + static constexpr uint8_t MaxNbForecastDays = 5; + enum class Icons : uint8_t { Sun = 0, // ClearSky CloudsSun = 1, // FewClouds @@ -96,7 +98,7 @@ namespace Pinetime { uint8_t iconId; }; - std::array days; + std::array days; }; std::optional Current() const;