Merge pull request #32 from lmammino/master

Updated Documentation annotations on factories
This commit is contained in:
Leszek Prabucki 2013-01-25 00:43:21 -08:00
commit c3b489721b
4 changed files with 12 additions and 25 deletions

3
.gitignore vendored
View File

@ -1 +1,4 @@
Tests/Resources/cache
.idea/
vendor/
composer.lock

View File

@ -10,12 +10,8 @@ use Symfony\Component\DependencyInjection\ContainerBuilder;
class AclAwareAmazonS3AdapterFactory implements AdapterFactoryInterface
{
/**
* Creates the adapter, registers it and returns its id
*
* @param ContainerBuilder $container A ContainerBuilder instance
* @param string $id The id of the service
* @param array $config An array of configuration
*/
* {@inheritDoc}
*/
public function create(ContainerBuilder $container, $id, array $config)
{
$container
@ -42,9 +38,7 @@ class AclAwareAmazonS3AdapterFactory implements AdapterFactoryInterface
}
/**
* Returns the key for the factory configuration
*
* @return string
* {@inheritDoc}
*/
public function getKey()
{
@ -52,9 +46,7 @@ class AclAwareAmazonS3AdapterFactory implements AdapterFactoryInterface
}
/**
* Adds configuration nodes for the factory
*
* @param NodeBuilder $builder
* {@inheritDoc}
*/
public function addConfiguration(NodeDefinition $builder)
{

View File

@ -31,7 +31,7 @@ interface AdapterFactoryInterface
/**
* Adds configuration nodes for the factory
*
* @param NodeBuilder $builder
* @param NodeDefinition $builder
*/
function addConfiguration(NodeDefinition $builder);
}

View File

@ -10,12 +10,8 @@ use Symfony\Component\DependencyInjection\ContainerBuilder;
class AmazonS3AdapterFactory implements AdapterFactoryInterface
{
/**
* Creates the adapter, registers it and returns its id
*
* @param ContainerBuilder $container A ContainerBuilder instance
* @param string $id The id of the service
* @param array $config An array of configuration
*/
* {@inheritDoc}
*/
public function create(ContainerBuilder $container, $id, array $config)
{
$definition = $container
@ -31,9 +27,7 @@ class AmazonS3AdapterFactory implements AdapterFactoryInterface
}
/**
* Returns the key for the factory configuration
*
* @return string
* {@inheritDoc}
*/
public function getKey()
{
@ -41,9 +35,7 @@ class AmazonS3AdapterFactory implements AdapterFactoryInterface
}
/**
* Adds configuration nodes for the factory
*
* @param NodeBuilder $builder
* {@inheritDoc}
*/
public function addConfiguration(NodeDefinition $builder)
{