timeout if cycling a server takes longer than inservice_time_allowed

bin/aws-ha-release.rb

@@ -3,6 +3,7 @@
 begin
   require 'aws-sdk'
   require 'trollop'
+  require 'timeout'
 rescue LoadError => e
   puts "The #{e.message.split('-').last.strip} gem must be installed."
   raise

lib/aws-missing-tools/aws-ha-release/aws-ha-release.rb

@@ -1,3 +1,5 @@
+require 'timeout'
+
 class AwsHaRelease
   attr_reader :group
 
@@ -13,6 +15,7 @@ class AwsHaRelease
 
     @max_size_change = 0
     @inservice_polling_time = 10
+    @opts = opts
   end
 
   def execute!
@@ -26,13 +29,15 @@ class AwsHaRelease
     @group.update(desired_capacity: @group.desired_capacity + 1)
 
     @group.ec2_instances.each do |instance|
-      until all_instances_inservice?(@group.load_balancers)
-        sleep @inservice_polling_time
-      end
+      Timeout::timeout(@opts[:inservice_time_allowed]) do
+        until all_instances_inservice?(@group.load_balancers)
+          sleep @inservice_polling_time
+        end
 
-      deregister_instance instance, @group.load_balancers
-      sleep opts[:elb_timeout]
-      instance.terminate false
+        deregister_instance instance, @group.load_balancers
+        sleep @opts[:elb_timeout]
+        instance.terminate false
+      end
     end
 
     @group.update(desired_capacity: @group.desired_capacity - 1)

spec/aws-missing-tools/aws-ha-release/aws-ha-release_spec.rb

@@ -6,7 +6,9 @@ describe 'aws-ha-release' do
       as_group_name: 'test_group',
       aws_access_key: 'testaccesskey',
       aws_secret_key: 'testsecretkey',
-      region: 'test-region'
+      region: 'test-region',
+      inservice_time_allowed: 300,
+      elb_timeout: 0
     }
   end
 

spec/support/fake_auto_scaling.rb

@@ -48,7 +48,11 @@ module AWS
       end
 
       def ec2_instances
-        []
+        @ec2_instances ||= [AWS::FakeEC2::Instance.new, AWS::FakeEC2::Instance.new]
+      end
+
+      def load_balancers
+        @load_balancers ||= AWS::FakeELB::LoadBalancerCollection.new
       end
     end
   end

spec/support/fake_ec2.rb

@@ -6,6 +6,9 @@ module AWS
     class Instance
       def initialize
       end
+
+      def terminate(decrement_desired_capacity)
+      end
     end
   end
 end

spec/support/fake_elb.rb

@@ -12,6 +12,11 @@ module AWS
       end
     end
 
+    class LoadBalancerCollection < Array
+      def initialize
+      end
+    end
+
     class InstanceCollection < Array
       def initialize
       end