From 0b3248418441ac68a09621e49a61052800a06e4b Mon Sep 17 00:00:00 2001 From: Olle Jonsson Date: Sat, 19 Mar 2016 15:22:45 +0100 Subject: [PATCH] Spec: rename local to noun --- spec/unit/parse_file_spec.rb | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/spec/unit/parse_file_spec.rb b/spec/unit/parse_file_spec.rb index 5eac4c4..735f32e 100644 --- a/spec/unit/parse_file_spec.rb +++ b/spec/unit/parse_file_spec.rb @@ -2,17 +2,17 @@ describe GitHubChangelogGenerator::ParserFile do describe ".github_changelog_generator" do context "when no has file" do let(:options) { {} } - let(:parse) { GitHubChangelogGenerator::ParserFile.new(options) } - subject { parse.parse! } + let(:parser) { GitHubChangelogGenerator::ParserFile.new(options) } + subject { parser.parse! } it { is_expected.to be_nil } end context "when file is empty" do let(:options) { {} } - let(:parse) { GitHubChangelogGenerator::ParserFile.new(options, StringIO.new("")) } + let(:parser) { GitHubChangelogGenerator::ParserFile.new(options, StringIO.new("")) } it "does not change the options" do - expect { parse.parse! }.to_not change { options } + expect { parser.parse! }.to_not change { options } end end @@ -20,10 +20,10 @@ describe GitHubChangelogGenerator::ParserFile do let(:options) { {} } let(:options_before_change) { options.dup } let(:file) { StringIO.new("unreleased_label=staging\nunreleased: false") } - let(:parse) do + let(:parser) do GitHubChangelogGenerator::ParserFile.new(options, file) end - it { expect { parse.parse! }.to raise_error(/line #2/) } + it { expect { parser.parse! }.to raise_error(/line #2/) } end context "when override default values" do @@ -31,10 +31,10 @@ describe GitHubChangelogGenerator::ParserFile do let(:options) { {}.merge(default_options) } let(:options_before_change) { options.dup } let(:file) { StringIO.new("unreleased_label=staging\nunreleased=false\nheader==== Changelog ===") } - let(:parse) { GitHubChangelogGenerator::ParserFile.new(options, file) } + let(:parser) { GitHubChangelogGenerator::ParserFile.new(options, file) } it "changes the options" do - expect { parse.parse! }.to change { options } + expect { parser.parse! }.to change { options } .from(options_before_change) .to(options_before_change.merge(unreleased_label: "staging", unreleased: false, @@ -50,13 +50,13 @@ EOF ) end it "reads exclude_labels into an Array" do - expect { parse.parse! }.to change { options[:exclude_labels] } + expect { parser.parse! }.to change { options[:exclude_labels] } .from(default_options[:exclude_labels]) .to(["73a91042-da6f-11e5-9335-1040f38d7f90", "7adf83b4-da6f-11e5-ae18-1040f38d7f90"]) end it "translates given header_label into the :header option" do - expect { parse.parse! }.to change { options[:header] } + expect { parser.parse! }.to change { options[:header] } .from(default_options[:header]) .to("# My changelog") end