From 2f179649b9e85557b0f5e6541f91f7cc088a594b Mon Sep 17 00:00:00 2001 From: John Keiser Date: Wed, 24 Feb 2016 11:05:54 -0800 Subject: [PATCH 1/2] Add rubocop and rspec as runtime dependencies --- Gemfile | 2 -- github_changelog_generator.gemspec | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile b/Gemfile index 8452dc5..0724b52 100644 --- a/Gemfile +++ b/Gemfile @@ -3,8 +3,6 @@ source "https://rubygems.org" gemspec group :test do - gem "rspec", "~>3.2" - gem "rubocop", "~>0.31" gem "coveralls", "~>0.8", require: false gem "simplecov", "~>0.10", require: false gem "codeclimate-test-reporter", "~>0.4" diff --git a/github_changelog_generator.gemspec b/github_changelog_generator.gemspec index 3fe5427..7a259f9 100644 --- a/github_changelog_generator.gemspec +++ b/github_changelog_generator.gemspec @@ -29,4 +29,6 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency("github_api", ["~> 0.12"]) spec.add_runtime_dependency("colorize", ["~> 0.7"]) spec.add_runtime_dependency("overcommit", "~>0.31") + spec.add_runtime_dependency("rubocop", "~>0.31") + spec.add_runtime_dependency("rspec", "~>3.2") end From b5df8e1e7675d3dc372dad4fe4f620d2f7fd4922 Mon Sep 17 00:00:00 2001 From: John Keiser Date: Wed, 24 Feb 2016 12:55:39 -0800 Subject: [PATCH 2/2] Use less restrictive versioning so we don't block other projects --- Gemfile.lock | 10 +++++----- github_changelog_generator.gemspec | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 0c06236..78b4b82 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,11 +2,13 @@ PATH remote: . specs: github_changelog_generator (1.10.4) - bundler (~> 1.7) + bundler (>= 1.7) colorize (~> 0.7) github_api (~> 0.12) - overcommit (~> 0.31) - rake (~> 10.0) + overcommit (>= 0.31) + rake (>= 10.0) + rspec (>= 3.2) + rubocop (>= 0.31) GEM remote: https://rubygems.org/ @@ -99,8 +101,6 @@ DEPENDENCIES codeclimate-test-reporter (~> 0.4) coveralls (~> 0.8) github_changelog_generator! - rspec (~> 3.2) - rubocop (~> 0.31) simplecov (~> 0.10) BUNDLED WITH diff --git a/github_changelog_generator.gemspec b/github_changelog_generator.gemspec index 7a259f9..a8ad97a 100644 --- a/github_changelog_generator.gemspec +++ b/github_changelog_generator.gemspec @@ -24,11 +24,11 @@ Gem::Specification.new do |spec| spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_runtime_dependency "rake", "~> 10.0" - spec.add_runtime_dependency "bundler", "~> 1.7" + spec.add_runtime_dependency "rake", ">= 10.0" + spec.add_runtime_dependency "bundler", ">= 1.7" spec.add_runtime_dependency("github_api", ["~> 0.12"]) spec.add_runtime_dependency("colorize", ["~> 0.7"]) - spec.add_runtime_dependency("overcommit", "~>0.31") - spec.add_runtime_dependency("rubocop", "~>0.31") - spec.add_runtime_dependency("rspec", "~>3.2") + spec.add_runtime_dependency("overcommit", ">= 0.31") + spec.add_runtime_dependency("rubocop", ">= 0.31") + spec.add_runtime_dependency("rspec", ">= 3.2") end