Refactoring: introduce local, return early

- use #reject
  - add basic spec around it
This commit is contained in:
Olle Jonsson
2016-02-23 23:04:43 +01:00
parent 4ceb065cae
commit 87b9962a8d
2 changed files with 21 additions and 6 deletions

View File

@@ -4,13 +4,12 @@ module GitHubChangelogGenerator
# @param [Array] issues
# @return [Array] filtered array
def exclude_issues_by_labels(issues)
unless @options[:exclude_labels].nil?
issues = issues.select do |issue|
var = issue.labels.map(&:name) & @options[:exclude_labels]
!var.any?
end
return issues if !@options[:exclude_labels] || @options[:exclude_labels].empty?
issues.reject do |issue|
labels = issue.labels.map(&:name)
(labels & @options[:exclude_labels]).any?
end
issues
end
# @return [Array] filtered issues accourding milestone