will/github-changelog-generator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

thread saety fix

Browse Source
This commit is contained in:
Petr Korolev 2015-02-17 21:18:52 +02:00
parent a6897c6a86
commit 9525cdeba8
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/github_changelog_generator.rb
View File

@ -161,10 +161,15 @@ module GitHubChangelogGenerator
def generate_log_for_all_tags def generate_log_for_all_tags
log = '' log = ''
if @options[:verbose]
puts "Fetching tags dates.."
end
# Async fetching tags: # Async fetching tags:
threads = [] threads = []
@all_tags.each { |tag| @all_tags.each { |tag|
threads << Thread.new { self.get_time_of_tag(tag) } # explicit set @tag_times_hash to write data safety.
threads << Thread.new { self.get_time_of_tag(tag, @tag_times_hash) }
} }
threads.each { |thr| thr.join } threads.each { |thr| thr.join }
@ -394,19 +399,18 @@ module GitHubChangelogGenerator
log log
end end
def get_time_of_tag(tag_name) def get_time_of_tag(tag_name, tag_times_hash = @tag_times_hash)
if tag_name.nil? if tag_name.nil?
return nil return nil
end end
if @tag_times_hash[tag_name['name']] if tag_times_hash[tag_name['name']]
return @tag_times_hash[tag_name['name']] return @tag_times_hash[tag_name['name']]
end end
github_git_data_commits_get = @github.git_data.commits.get @options[:user], @options[:project], tag_name['commit']['sha'] github_git_data_commits_get = @github.git_data.commits.get @options[:user], @options[:project], tag_name['commit']['sha']
time_string = github_git_data_commits_get['committer']['date'] time_string = github_git_data_commits_get['committer']['date']
Time.parse(time_string)
@tag_times_hash[tag_name['name']] = Time.parse(time_string) @tag_times_hash[tag_name['name']] = Time.parse(time_string)
end end