will/github-changelog-generator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid nil bug in detect_since_tag

Browse Source
This commit is contained in:
Olle Jonsson
2016-04-16 23:20:36 +02:00
committed by Olle Jonsson
parent 253fe49648
commit 9c6068f026
2 changed files with 27 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/github_changelog_generator/generator/generator_tags.rb
View File

@@ -54,13 +54,14 @@ module GitHubChangelogGenerator
# @return [Object] try to find newest tag using #Reader and :base option if specified otherwise returns nil
def detect_since_tag
@since_tag ||= @options[:since_tag]
if @since_tag.nil? && @options[:base] && File.file?(@options[:base])
reader = GitHubChangelogGenerator::Reader.new
content = reader.read(@options[:base])
@since_tag = content[0]["version"] if content.count && content
end
@since_tag
@since_tag ||= @options.fetch(:since_tag) { version_of_first_item }
end
def version_of_first_item
return unless File.file?(@options[:base].to_s)
sections = GitHubChangelogGenerator::Reader.new.read(@options[:base])
sections.first["version"] if sections && sections.any?
end
# Return tags after filtering tags in lists provided by option: --between-tags & --exclude-tags