will/github-changelog-generator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add doc fix bug with filtering in case of nil issues

Browse Source
This commit is contained in:
Petr Korolev 2015-04-04 03:18:12 +03:00
parent 177b7aa18f
commit c44be45ce4
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/github_changelog_generator.rb
View File

@ -153,8 +153,6 @@ module GitHubChangelogGenerator
def get_filtered_pull_requests def get_filtered_pull_requests
fetch_merged_at_pull_requests fetch_merged_at_pull_requests
# filtered_pull_requests = @pull_requests.select { |pr| !pr[:merged_at].nil? }
filtered_pull_requests = include_issues_by_labels(@pull_requests) filtered_pull_requests = include_issues_by_labels(@pull_requests)
filtered_pull_requests = exclude_issues_by_labels(filtered_pull_requests) filtered_pull_requests = exclude_issues_by_labels(filtered_pull_requests)
@ -166,20 +164,19 @@ module GitHubChangelogGenerator
filtered_pull_requests filtered_pull_requests
end end
# Include issues with labels, specified in :include_labels
# @param [Array] issues to filter
# @return [Array] filtered array of issues
def include_issues_by_labels(issues) def include_issues_by_labels(issues)
unless @options[:include_labels].nil? filtered_issues = @options[:include_labels].nil? ? issues : issues.select { |issue| (issue.labels.map(&:name) & @options[:include_labels]).any? }
_issues = issues.select { |issue|
(issue.labels.map(&:name) & @options[:include_labels]).any?
}
end
if @options[:add_issues_wo_labels] if @options[:add_issues_wo_labels]
issues_wo_labels = issues.select { |issue| issues_wo_labels = issues.select { |issue|
!issue.labels.map(&:name).any? !issue.labels.map(&:name).any?
} }
_issues |= issues_wo_labels filtered_issues |= issues_wo_labels
end end
_issues filtered_issues
end end
# delete all labels with labels from @options[:exclude_labels] array # delete all labels with labels from @options[:exclude_labels] array