Merge branch 'cleanup' of https://github.com/tuexss/github-changelog-generator into cleanup
This commit is contained in:
commit
c5a01bb24f
|
@ -15,8 +15,8 @@ module GitHubChangelogGenerator
|
||||||
attr_accessor :options, :all_tags, :github
|
attr_accessor :options, :all_tags, :github
|
||||||
|
|
||||||
PER_PAGE_NUMBER = 30
|
PER_PAGE_NUMBER = 30
|
||||||
GH_RATE_LIMIT_EXCEEDED_MSG = "Warning: GitHub API rate limit (5000 per hour) exceeded, change log may be " \
|
GH_RATE_LIMIT_EXCEEDED_MSG = 'Warning: GitHub API rate limit (5000 per hour) exceeded, change log may be ' \
|
||||||
"missing some issues. You can limit the number of issues fetched using the `--max-issues NUM` argument."
|
'missing some issues. You can limit the number of issues fetched using the `--max-issues NUM` argument.'
|
||||||
|
|
||||||
def initialize
|
def initialize
|
||||||
@options = Parser.parse_options
|
@options = Parser.parse_options
|
||||||
|
@ -139,7 +139,7 @@ module GitHubChangelogGenerator
|
||||||
}
|
}
|
||||||
|
|
||||||
if @options[:verbose]
|
if @options[:verbose]
|
||||||
puts "Fetching merged dates: Done!"
|
puts 'Fetching merged dates: Done!'
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -210,7 +210,7 @@ module GitHubChangelogGenerator
|
||||||
|
|
||||||
output_filename = "#{@options[:output]}"
|
output_filename = "#{@options[:output]}"
|
||||||
File.open(output_filename, 'w') { |file| file.write(log) }
|
File.open(output_filename, 'w') { |file| file.write(log) }
|
||||||
puts "Done!"
|
puts 'Done!'
|
||||||
puts "Generated log placed in #{`pwd`.strip!}/#{output_filename}"
|
puts "Generated log placed in #{`pwd`.strip!}/#{output_filename}"
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -218,13 +218,13 @@ module GitHubChangelogGenerator
|
||||||
fetch_tags_dates
|
fetch_tags_dates
|
||||||
|
|
||||||
if @options[:verbose]
|
if @options[:verbose]
|
||||||
puts "Sorting tags..."
|
puts 'Sorting tags...'
|
||||||
end
|
end
|
||||||
|
|
||||||
@all_tags.sort_by! { |x| get_time_of_tag(x) }.reverse!
|
@all_tags.sort_by! { |x| get_time_of_tag(x) }.reverse!
|
||||||
|
|
||||||
if @options[:verbose]
|
if @options[:verbose]
|
||||||
puts "Generating log..."
|
puts 'Generating log...'
|
||||||
end
|
end
|
||||||
|
|
||||||
log = ''
|
log = ''
|
||||||
|
@ -310,8 +310,8 @@ module GitHubChangelogGenerator
|
||||||
env_var = @options[:token] ? @options[:token] : (ENV.fetch 'CHANGELOG_GITHUB_TOKEN', nil)
|
env_var = @options[:token] ? @options[:token] : (ENV.fetch 'CHANGELOG_GITHUB_TOKEN', nil)
|
||||||
|
|
||||||
unless env_var
|
unless env_var
|
||||||
puts "Warning: No token provided (-t option) and variable $CHANGELOG_GITHUB_TOKEN was not found.".yellow
|
puts 'Warning: No token provided (-t option) and variable $CHANGELOG_GITHUB_TOKEN was not found.'.yellow
|
||||||
puts "This script can make only 50 requests per hour to GitHub API without a token!".yellow
|
puts 'This script can make only 50 requests per hour to GitHub API without a token!'.yellow
|
||||||
end
|
end
|
||||||
|
|
||||||
@github_token ||= env_var
|
@github_token ||= env_var
|
||||||
|
@ -375,7 +375,7 @@ module GitHubChangelogGenerator
|
||||||
end
|
end
|
||||||
|
|
||||||
def delete_by_time(array, hash_key, older_tag = nil, newer_tag = nil)
|
def delete_by_time(array, hash_key, older_tag = nil, newer_tag = nil)
|
||||||
fail "At least one of the tags should be not nil!" if older_tag.nil? && newer_tag.nil?
|
fail 'At least one of the tags should be not nil!' if older_tag.nil? && newer_tag.nil?
|
||||||
|
|
||||||
newer_tag_time = get_time_of_tag(newer_tag)
|
newer_tag_time = get_time_of_tag(newer_tag)
|
||||||
older_tag_time = get_time_of_tag(older_tag)
|
older_tag_time = get_time_of_tag(older_tag)
|
||||||
|
|
Loading…
Reference in New Issue
Block a user