will/github-changelog-generator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #407 from jkeiser/jk/thread-cap

Browse Source 
Limit number of simultaneous requests to 25
This commit is contained in:
Olle Jonsson 2016-08-10 09:19:42 +02:00 committed by GitHub
commit cbb435511b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/github_changelog_generator/fetcher.rb
View File

@ -7,6 +7,7 @@ module GitHubChangelogGenerator
class Fetcher class Fetcher
PER_PAGE_NUMBER = 30 PER_PAGE_NUMBER = 30
MAX_SIMULTANEOUS_REQUESTS = 25
CHANGELOG_GITHUB_TOKEN = "CHANGELOG_GITHUB_TOKEN" CHANGELOG_GITHUB_TOKEN = "CHANGELOG_GITHUB_TOKEN"
GH_RATE_LIMIT_EXCEEDED_MSG = "Warning: Can't finish operation: GitHub API rate limit exceeded, change log may be " \ GH_RATE_LIMIT_EXCEEDED_MSG = "Warning: Can't finish operation: GitHub API rate limit exceeded, change log may be " \
"missing some issues. You can limit the number of issues fetched using the `--max-issues NUM` argument." "missing some issues. You can limit the number of issues fetched using the `--max-issues NUM` argument."
@ -166,9 +167,8 @@ Make sure, that you push tags to remote repo via 'git push --tags'".yellow
# @return [Void] # @return [Void]
def fetch_events_async(issues) def fetch_events_async(issues)
i = 0 i = 0
max_thread_number = 50
threads = [] threads = []
issues.each_slice(max_thread_number) do |issues_slice| issues.each_slice(MAX_SIMULTANEOUS_REQUESTS) do |issues_slice|
issues_slice.each do |issue| issues_slice.each do |issue|
threads << Thread.new do threads << Thread.new do
begin begin