Commit Graph

80 Commits

Author SHA1 Message Date
Andrew Waage
074b467251 added specs and refactor a bit 2016-10-07 16:58:38 -07:00
Olle Jonsson
e123466b82 Linting 2016-10-05 23:31:19 +02:00
Olle Jonsson
c1f6fce86c Options: add error class, refactor
- improve readability of specs
  - extract methods
2016-10-05 23:12:48 +02:00
Olle Jonsson
43a6e49055 Options: a class to wrap Hash-accessing options choices
- protects against bad names
2016-10-05 23:10:21 +02:00
Olle Jonsson
828d639348 Spec: Test a url helper function (#428) 2016-10-01 19:23:48 +02:00
Olle Jonsson
d8b34169a3 Linting 2016-09-29 23:09:04 +02:00
Olle Jonsson
da0024cbdf GeneratorTagsSpec: change name of a test 2016-09-29 23:09:04 +02:00
Olle Jonsson
8769ced74e OctoFetcher spec: The new assignees field 2016-09-29 23:09:04 +02:00
Olle Jonsson
49b62a9d23 Style: use the short form for RSpec metadata 2016-09-29 23:09:04 +02:00
Olle Jonsson
1177f09ca5 Drop Hashie dependency 2016-09-29 23:09:04 +02:00
Olle Jonsson
ad44c035f0 WIP Remove github_api gem, smaller dependencies
- use VCR with metadata instead of macros
  - upgrade colorize gem
2016-09-29 23:09:04 +02:00
Andrew Waage
ef9867c122 fixing rubocop and removing original fetcher 2016-09-29 23:09:04 +02:00
Andrew Waage
71c5348bdb made old fetcher compatible 2016-09-29 23:09:04 +02:00
Andrew Waage
a17931f3d4 fixing specs 2016-09-29 23:09:04 +02:00
Andrew Waage
2347cc4220 added specs for the new octo_fetcher. Also had to refactor a bit to deal with hashes and arrays instead of objects 2016-09-29 23:09:04 +02:00
Andrew Waage
8277aa4319 added VCR and specs for original fetcher 2016-09-29 23:09:04 +02:00
Olle Jonsson
5c21fc980f Rubocop setting: avoid copping the universe 2016-09-22 19:04:35 +02:00
Olle Jonsson
91b5abc477 Spec: avoid warning when stubbing ARGV 2016-09-01 20:47:31 +02:00
Petr Korolev
37a7430d81 add test 2016-07-21 17:48:47 +03:00
Petr Korolev
430d6f5bd9 add missing test 2016-07-21 17:47:53 +03:00
John Keiser
c0c8bb5653 Don't constrain runtime deps.
Since we are a development dependency of many projects,
constraining our runtime deps can cause their Gemfiles to downgrade
dependencies they share with us, which is never desirable.
2016-07-21 17:47:52 +03:00
Olle Jonsson
cc653b6b21 linting 2016-04-18 16:53:45 +02:00
Olle Jonsson
9ce5c76d4a Linting 2016-04-18 16:53:25 +02:00
Olle Jonsson
86ca388ecf Spec: Smaller help functions 2016-04-18 16:53:25 +02:00
Olle Jonsson
9c6068f026 Avoid nil bug in detect_since_tag 2016-04-18 16:53:25 +02:00
Petr Korolev
519ca91cd7 Merge pull request #320 from ITV/filter-tags
Added tag exclusion with a filter (string or regex)
2016-03-28 13:04:06 +03:00
Adam
507ffdb910 put filter_excluded_tags_regex after filter_excluded_tags tests 2016-03-24 13:00:53 +00:00
Adam
21d41756b8 regex test include regex identifier 2016-03-24 13:00:02 +00:00
Adam
17ceccdd70 clean up test description 2016-03-24 12:54:19 +00:00
Adam
e5a619b167 add test for #filter_excluded_tags_regex with non-matching regex in exclude_tags 2016-03-24 12:06:39 +00:00
Adam
dd149d7ad9 implement #filter_excluded_tags_regex with regex exclude_tags 2016-03-24 11:59:20 +00:00
Olle Jonsson
0fccc4396f ParserFile: Config format allows empty lines
- defined as: lines that consist only of whitespace
2016-03-19 17:12:30 +01:00
Olle Jonsson
068af037f5 Spec: use RSpec contexts 2016-03-19 16:54:13 +01:00
Olle Jonsson
4569fad479 ParserFile: Allow comments in settings file
- Ruby-style or semi-colon-style accepted
2016-03-19 16:50:39 +01:00
Olle Jonsson
0b32484184 Spec: rename local to noun 2016-03-19 15:22:45 +01:00
Olle Jonsson
a997d2417d Spec: Config parse fail message tested 2016-03-19 15:20:48 +01:00
Olle Jonsson
93df2d5646 ParserFile: use a File instead of a filename
- spec: can use StringIOs instead of loose files
2016-03-19 13:59:58 +01:00
Olle Jonsson
655aa965a7 Spec: option name translation tested 2016-03-17 21:38:28 +01:00
Olle Jonsson
44bbd9ca01 Parse options file options
- this proof-of-concept code duplicates OptionParser information to
   get something going
 - take care to respect the type of each option from the OptionParser
2016-03-17 20:39:49 +01:00
Petr Korolev
9a217e3468 rubocop correction 2016-02-24 16:31:18 +02:00
Petr Korolev
035e160f5e Merge pull request #332 from olleolleolle/feature/exclude-issues-by-labels
[Refactor] Generator#exclude_issues_by_labels simpler, tested
2016-02-24 16:30:14 +02:00
Petr Korolev
63c70edb25 add pending message 2016-02-24 15:10:32 +02:00
Petr Korolev
0b3e8429c4 rubocop fixes 2016-02-24 15:10:32 +02:00
Olle Jonsson
bc6bfac2a3 Typo 2016-02-24 15:10:32 +02:00
Olle Jonsson
575f42f652 Test case for #327 2016-02-24 15:10:32 +02:00
Olle Jonsson
89d1b5393d Generator#exclude_issues_by_labels spec clearer 2016-02-23 23:23:54 +01:00
Olle Jonsson
87b9962a8d Refactoring: introduce local, return early
- use #reject
  - add basic spec around it
2016-02-23 23:17:37 +01:00
Olle Jonsson
540251ab60 Typo 2016-02-23 22:28:24 +01:00
Olle Jonsson
b8f7dbaa2e Test case for #327 2016-02-23 22:24:10 +01:00
Petr Korolev
2691a3ef96 Revert "Rubocop fixes"
This reverts commit fa0267b586.
2016-02-23 17:19:14 +02:00