Compare commits

..

11 Commits
1.8.2 ... 1.8.3

Author SHA1 Message Date
Petr Korolev
5df78f22d1 Merge branch 'release/1.8.3' 2015-08-31 15:41:27 +03:00
Petr Korolev
b0f264a928 Update gemspec to version 1.8.3 2015-08-31 15:41:25 +03:00
Petr Korolev
ea4a604bcb update gitignore 2015-08-31 15:35:01 +03:00
Raphaël Pinson
1ec72afe32 Do not alter pull_requests while iterating on it
Deleting elements of an array while iterating on it
results in never seeing the last element.

    > a = [1,2,3]
     => [1, 2, 3]
    > a.each do |e|
    >   p a
    >   a.delete(e)
    > end
    [1, 2, 3]
    [2, 3]
     => [2]
2015-08-31 15:15:42 +03:00
Petr Korolev
127ffee93f Merge pull request #271 from raphink/dev/pr_delete
Do not alter pull_requests while iterating on it
2015-08-27 14:59:06 +03:00
Raphaël Pinson
6a732ceb99 Do not alter pull_requests while iterating on it
Deleting elements of an array while iterating on it
results in never seeing the last element.

    > a = [1,2,3]
     => [1, 2, 3]
    > a.each do |e|
    >   p a
    >   a.delete(e)
    > end
    [1, 2, 3]
    [2, 3]
     => [2]
2015-08-27 13:36:41 +02:00
Petr Korolev
0140986091 Merge branch 'hotfix/update-changelog' into develop 2015-08-26 17:06:17 +03:00
Petr Korolev
312fe3d45a Merge branch 'hotfix/update-changelog' 2015-08-26 17:06:17 +03:00
Petr Korolev
be2340ddcb http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ 2015-08-26 17:06:07 +03:00
Petr Korolev
f29061e75a Update changelog for version 1.8.2 2015-08-26 17:02:49 +03:00
Petr Korolev
de531262c8 Merge branch 'release/1.8.2' into develop 2015-08-26 17:02:02 +03:00
3 changed files with 12 additions and 5 deletions

View File

@@ -1,5 +1,12 @@
# Change Log
## [1.8.2](https://github.com/skywinder/github-changelog-generator/tree/1.8.2) (2015-08-26)
[Full Changelog](https://github.com/skywinder/github-changelog-generator/compare/1.8.1...1.8.2)
**Closed issues:**
- Output should not include security information [\#270](https://github.com/skywinder/github-changelog-generator/issues/270)
## [1.8.1](https://github.com/skywinder/github-changelog-generator/tree/1.8.1) (2015-08-25)
[Full Changelog](https://github.com/skywinder/github-changelog-generator/compare/1.8.0...1.8.1)

View File

@@ -120,22 +120,22 @@ module GitHubChangelogGenerator
issues_a.push dict unless added
end
added_pull_requests = []
pull_requests.each do |dict|
added = false
dict.labels.each do |label|
if @options[:bug_labels].include? label.name
bugs_a.push dict
added = true
added_pull_requests.push dict
next
end
if @options[:enhancement_labels].include? label.name
enhancement_a.push dict
added = true
added_pull_requests.push dict
next
end
end
pull_requests.delete(dict) if added
end
added_pull_requests.each { |p| pull_requests.delete(p) }
[bugs_a, enhancement_a, issues_a]
end

View File

@@ -1,3 +1,3 @@
module GitHubChangelogGenerator
VERSION = "1.8.2"
VERSION = "1.8.3"
end