From 18bf03239ffa384d7b8e9d4f9d2155b4c83178ef Mon Sep 17 00:00:00 2001 From: Alan Grainger <16197738+alangrainger@users.noreply.github.com> Date: Fri, 10 Oct 2025 16:27:33 +0800 Subject: [PATCH] #140 allow non-ASCII characters in downloaded zip filename --- app/package.json | 2 +- app/src/includes/sanitize.js | 2 +- app/src/render.ts | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/package.json b/app/package.json index 296e37e..86cfbb5 100644 --- a/app/package.json +++ b/app/package.json @@ -1,6 +1,6 @@ { "name": "immich-public-proxy", - "version": "1.13.3", + "version": "1.13.4", "scripts": { "dev": "ts-node src/index.ts", "build": "npx tsc", diff --git a/app/src/includes/sanitize.js b/app/src/includes/sanitize.js index 693103c..b390026 100644 --- a/app/src/includes/sanitize.js +++ b/app/src/includes/sanitize.js @@ -1,5 +1,5 @@ /** - * From https://github.com/parshap/node-sanitize-filename + * From https://www.npmjs.com/package/sanitize-filename * * Replaces characters in strings that are illegal/unsafe for filenames. * Unsafe characters are either removed or replaced by a substitute set diff --git a/app/src/render.ts b/app/src/render.ts index 880c533..e6b1546 100644 --- a/app/src/render.ts +++ b/app/src/render.ts @@ -171,8 +171,9 @@ class Render { */ async downloadAll (res: Response, share: SharedLink) { res.setHeader('Content-Type', 'application/zip') - const title = (sanitize(this.title(share)) || 'photos') + '.zip' - res.setHeader('Content-Disposition', `attachment; filename="${title}"`) + let filename = (sanitize(this.title(share)) || 'photos') + '.zip' + filename = encodeURI(filename) + res.setHeader('Content-Disposition', `attachment; filename*=UTF-8''${filename}`) const archive = archiver('zip', { zlib: { level: 6 } }) archive.pipe(res) for (const asset of share.assets) {