Separate upload-ok

This commit is contained in:
Alan Grainger
2026-10-17 16:10:48 +13:00
parent c739e931ea
commit 396bf7bede
7 changed files with 77 additions and 19 deletions
+1 -1
View File
@@ -142,7 +142,7 @@ With it off, a slug link gets a 404 and only the key form works.
Where the optional upload service (the `immich-public-proxy-upload` container) is served. A share whose "Allow public user to upload" option is on in Immich then shows an "Add photos" button in the gallery header, which opens that share's page on the upload service. To set up the service, see [Let visitors send photos back](/visitor-uploads).
- **A path**, such as the default `/upload`, means the service is on IPP's own hostname under that path. Before showing the button, the gallery page checks that the upload service answers `ok` at `<path>/healthcheck`, so an install without the upload container never shows a dead button. When nothing is routed there, IPP answers that path itself with an empty 204.
- **A path**, such as the default `/upload`, means the service is on IPP's own hostname under that path. Before showing the button, the gallery page checks that the upload service answers `upload-ok` at `<path>/healthcheck`, so an install without the upload container never shows a dead button. When nothing is routed there, IPP answers that path itself with an empty 204.
- **An absolute URL**, such as `https://upload.example.com`, means the service has a hostname of its own. It is trusted without a check. The URL may include a path, such as `https://photos.example.com/upload`, which points at the same place as the default but without the check.
- **An empty string** never shows the button.
+2 -2
View File
@@ -32,7 +32,7 @@ See [Request size limits](/visitor-uploads#request-size-limits).
## The "Add photos" button does not appear
The upload service runs and its `/healthcheck` answers `ok`, but a share with **Allow public user to upload** turned
The upload service runs and its `/healthcheck` answers `upload-ok`, but a share with **Allow public user to upload** turned
on shows no button in the gallery. View the gallery page's source and look for `id="upload-link"`:
- **The page source has no `upload-link`, and the script URL is `/share/static/3.x.x/...`.** IPP is still 3.x, which
@@ -42,7 +42,7 @@ on shows no button in the gallery. View the gallery page's source and look for `
upload option is off in Immich, or [`uploadUrl`](/config/ipp-options#uploadurl) is set to an empty string or
something other than a path or an absolute URL. A changed `config.json` or `CONFIG` needs a restart.
- **`upload-link` is there with a `hidden` attribute.** IPP assumed the service at `/upload` on its own hostname and
the browser's check of `/upload/healthcheck` there did not answer `ok`. Open that URL on the **gallery** hostname,
the browser's check of `/upload/healthcheck` there did not answer `upload-ok`. Open that URL on the **gallery** hostname,
for example `https://photos.example.com/upload/healthcheck`. An empty page means the reverse proxy sent the
request to IPP rather than to the upload service, so add or fix the `/upload` route. If the upload service has its
own hostname, set [`uploadUrl`](/config/ipp-options#uploadurl) to it in IPP's config; a setting elsewhere in the
+6 -3
View File
@@ -234,9 +234,12 @@ keys, and the upload service reads only those and [two shared options](/config/u
### Check the route
Open `/healthcheck` on the upload URL: `https://photos.example.com/upload/healthcheck` or
`https://upload.example.com/healthcheck`. It answers `ok` when the upload service can reach Immich, and a 503 when
it cannot. With the upload service on a path on the IPP hostname, IPP shows the **Add photos** button only while
this answers `ok`. With its own hostname, IPP shows the button whenever `uploadUrl` is set.
`https://upload.example.com/healthcheck`. It answers `upload-ok` when the upload service can reach Immich, and a
503 when it cannot. With the upload service on a path on the IPP hostname, IPP shows the **Add photos** button only
while this answers `upload-ok`. With its own hostname, IPP shows the button whenever `uploadUrl` is set.
A plain `ok` at `https://upload.example.com/healthcheck` means the hostname reached IPP, not the upload
service: IPP answers `ok` on its own `/healthcheck`. Point the upload hostname at the upload container's port.
An empty page at `https://photos.example.com/upload/healthcheck` means the request reached IPP, not the upload
service: IPP answers its own hostname's `/upload/healthcheck` with nothing when the route is missing. Check the