From 5884e5afc9130af4569c5bbdfd15ca17ed4e1b8c Mon Sep 17 00:00:00 2001 From: Alan Grainger <16197738+alangrainger@users.noreply.github.com> Date: Sat, 5 Sep 2026 06:12:54 +1200 Subject: [PATCH] Remove buffering for single downloads #94 --- app/src/stream/asset.ts | 19 +++++++++++-------- app/tests/assetStream.test.ts | 1 + 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/app/src/stream/asset.ts b/app/src/stream/asset.ts index f20940f..1b97319 100644 --- a/app/src/stream/asset.ts +++ b/app/src/stream/asset.ts @@ -96,14 +96,17 @@ export async function assetBuffer (req: IncomingShareRequest, res: Response, ass return } - if (attachment && asset.originalFileName) { - // Playback downloads serve Immich's transcode, so the filename extension - // must follow the response's content-type, not the original file's. - const playbackMime = useVideoPlayback - ? (data.headers.get('content-type') || '').split(';')[0].trim() || undefined - : undefined - const filename = encodeURI(getFilename(asset, servedSize, playbackMime)) - res.setHeader('Content-Disposition', `attachment; filename*=UTF-8''${filename}`) + if (attachment) { + res.setHeader('X-Accel-Buffering', 'no') + if (asset.originalFileName) { + // Playback downloads serve Immich's transcode, so the filename extension + // must follow the response's content-type, not the original file's. + const playbackMime = useVideoPlayback + ? (data.headers.get('content-type') || '').split(';')[0].trim() || undefined + : undefined + const filename = encodeURI(getFilename(asset, servedSize, playbackMime)) + res.setHeader('Content-Disposition', `attachment; filename*=UTF-8''${filename}`) + } } headerList.forEach(header => { const value = data.headers.get(header) diff --git a/app/tests/assetStream.test.ts b/app/tests/assetStream.test.ts index 6c591c1..2d048b5 100644 --- a/app/tests/assetStream.test.ts +++ b/app/tests/assetStream.test.ts @@ -118,6 +118,7 @@ describe('assetBuffer streaming', () => { expect(res.headers['content-type']).toBe('image/jpeg') expect(res.headers['content-length']).toBe(String(4 * CHUNK)) expect(res.headers['content-disposition']).toContain('a1.jpg') + expect(res.headers['x-accel-buffering']).toBe('no') }) it('applies backpressure so upstream is read no faster than the visitor drains it', async () => {