From 79346d9bc7d4942f4111442740a01877120525e1 Mon Sep 17 00:00:00 2001 From: Alan Grainger <16197738+alangrainger@users.noreply.github.com> Date: Thu, 28 May 2026 07:30:23 +0800 Subject: [PATCH] Fix #234 remove non-functional publicBaseUrl variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This should presumably not impact anyone. As mentioned in #234, Node lowercases incoming header keys, so the camelCase lookup `req.headers.publicBaseUrl` never matched any request. The header override has been dead code since it was added — operators relying on it would have silently been falling back to the Host header. If we add it back in, will need to do it in a way that solves for cache-poisoning. --- README.md | 8 -------- app/src/render.ts | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 4fe6026..48c8b01 100644 --- a/README.md +++ b/README.md @@ -253,14 +253,6 @@ You can customise the responses that IPP sends for invalid requests. For example See [Custom responses](docs/custom-responses.md) for more details. -### Serving from multiple domains - -If you're serving the same IPP from multiple domains, instead of setting the public URL in your docker-compose file, you can set it dynamically via a HTTP header in the request from your reverse proxy to IPP. - -1. Remove the `PUBLIC_BASE_URL` environment variable from your docker-compose file. - -2. Set a custom `publicBaseUrl` header on each request with the value of your public base URL (example `https://your-proxy-url.com`). - ## Troubleshooting ### Video playback diff --git a/app/src/render.ts b/app/src/render.ts index c4173fb..b344660 100644 --- a/app/src/render.ts +++ b/app/src/render.ts @@ -144,8 +144,8 @@ class Render { */ async gallery (res: Response, share: SharedLink, openItem?: number) { // publicBaseUrl is used for the og:image, which requires a fully qualified URL. - // You can specify this in your docker-compose file, or send it dynamically as a `publicBaseUrl` header - const publicBaseUrl = process.env.PUBLIC_BASE_URL || res.req.headers.publicBaseUrl || (res.req.protocol + '://' + res.req.headers.host) + // You can specify this in your docker-compose file via the PUBLIC_BASE_URL env var. + const publicBaseUrl = process.env.PUBLIC_BASE_URL || (res.req.protocol + '://' + res.req.headers.host) // Date grouping needs chronological order; sort newest-first when enabled // (overrides any album.order the upstream applied).