Guard sticky-tile registration against stale image loads

If a tile is virtualised out before its in-flight thumbnail finishes, the
load event still fires on the detached <img>. Without a guard that callback
would add the index to state.stickyTiles, potentially pinning a later
replacement tile whose own <img> has not painted yet.

Only register the index while this <a> is still the live tile for it
(state.renderedTiles.get(index) === a).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Vignan Posham
2026-09-07 01:38:19 -04:00
parent ec199961ea
commit 9b85b4e748
+5 -1
View File
@@ -78,7 +78,11 @@ export function createTile (index: number): HTMLAnchorElement {
// Pin this tile: once loaded it is never virtualised out again, so a // Pin this tile: once loaded it is never virtualised out again, so a
// scroll back up reuses this exact <img> instead of rebuilding it in a // scroll back up reuses this exact <img> instead of rebuilding it in a
// blank/placeholder state. See state.stickyTiles / virtualize(). // blank/placeholder state. See state.stickyTiles / virtualize().
state.stickyTiles.add(index) // Guard: if this tile was virtualised out before its (in-flight) image
// finished, the load still fires on the now-detached <img>. Only pin the
// index while this <a> is still the live tile for it, so a stale request
// can't mark a not-yet-loaded replacement tile as sticky.
if (state.renderedTiles.get(index) === a) state.stickyTiles.add(index)
} }
a.appendChild(img) a.appendChild(img)