From bbb4dd14916bf88d211baad03deb5bca06983d4a Mon Sep 17 00:00:00 2001 From: Alan Grainger <16197738+alangrainger@users.noreply.github.com> Date: Thu, 17 Sep 2026 22:08:47 +1200 Subject: [PATCH] Tidy up overly verbose LLM comments --- app/package-lock.json | 4 ++-- app/package.json | 2 +- app/src/client/state.ts | 22 +++++++--------------- app/src/client/tiles.ts | 9 ++------- app/src/client/virtualisation.ts | 16 +++------------- 5 files changed, 15 insertions(+), 38 deletions(-) diff --git a/app/package-lock.json b/app/package-lock.json index 87391d5..4fd920d 100644 --- a/app/package-lock.json +++ b/app/package-lock.json @@ -1,12 +1,12 @@ { "name": "immich-public-proxy", - "version": "3.3.2", + "version": "3.3.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "immich-public-proxy", - "version": "3.3.2", + "version": "3.3.1", "license": "AGPL-3.0", "dependencies": { "archiver": "^7.0.1", diff --git a/app/package.json b/app/package.json index 2659d07..953a77f 100644 --- a/app/package.json +++ b/app/package.json @@ -1,6 +1,6 @@ { "name": "immich-public-proxy", - "version": "3.3.2", + "version": "3.3.1", "scripts": { "dev": "concurrently -n server,client -c blue,green \"tsx watch src/index.ts\" \"tsc -w -p tsconfig.client.json\"", "build": "tsc && tsc -p tsconfig.client.json", diff --git a/app/src/client/state.ts b/app/src/client/state.ts index 746849d..2feac04 100644 --- a/app/src/client/state.ts +++ b/app/src/client/state.ts @@ -15,12 +15,7 @@ export const MOBILE_COLS = 3 export const IMAGE_LOAD_MARGIN_PX = 300 export const SCROLL_SETTLE_MS = 100 export const BUFFER_VIEWPORTS = 1 -// Upper bound on how many already-loaded tiles we keep permanently mounted -// (see state.stickyTiles). ~1500 covers dozens of screens of scroll-back so -// revisiting recently-seen thumbnails never flickers, while capping retained -// DOM / decoded-image memory so a 100k-photo album can't grow unbounded as -// the user scrolls. Least-recently-visible tiles past this count fall back to -// normal virtualisation and re-pin if scrolled back to. +// Cap on state.stickyTiles: dozens of screens of scroll-back, bounded DOM export const STICKY_TILE_LIMIT = 1500 // Height reserved for each month header (must agree with .group-header CSS) export const HEADER_HEIGHT = 48 @@ -80,15 +75,12 @@ export const state = { lastContainerW: 0, renderedTiles: new Map(), renderedHeaders: new Map(), - // Tile indices whose has fired `load` at least once. While an index - // is in this set virtualize() never removes its tile, so scrolling back to - // an already-seen thumbnail shows the cached image with no placeholder / - // fade-in flicker. Insertion order is maintained as most-recently-visible- - // last and the set is trimmed to STICKY_TILE_LIMIT each virtualize() pass, - // so a huge album can't accumulate unbounded mounted DOM. Tiles that have - // not loaded yet get the normal lazy create / remove treatment, so large - // albums still lazy-load on first scroll-into-view. Cleared on a layout - // recompute (see computeLayoutAndRender) because tile geometry changes. + /* + Indices of tiles whose has loaded. virtualize() never removes these, + so scrolling back reuses the mounted : no placeholder flicker and no + re-fetch (password-protected shares serve thumbnails `no-store`). Ordered + most-recently-visible last and trimmed to STICKY_TILE_LIMIT from the head. + */ stickyTiles: new Set(), // Selection mode (mode-toggle UX: hidden checkmarks until activated) selectMode: false, diff --git a/app/src/client/tiles.ts b/app/src/client/tiles.ts index 10f7feb..cf7fe38 100644 --- a/app/src/client/tiles.ts +++ b/app/src/client/tiles.ts @@ -75,13 +75,8 @@ export function createTile (index: number): HTMLAnchorElement { // white flash between `img.src` being set and the bytes actually painting). img.onload = () => { img.classList.add('loaded') - // Pin this tile: once loaded it is never virtualised out again, so a - // scroll back up reuses this exact instead of rebuilding it in a - // blank/placeholder state. See state.stickyTiles / virtualize(). - // Guard: if this tile was virtualised out before its (in-flight) image - // finished, the load still fires on the now-detached . Only pin the - // index while this is still the live tile for it, so a stale request - // can't mark a not-yet-loaded replacement tile as sticky. + // Pin the tile (see state.stickyTiles) unless it was virtualised out + // mid-load, in which case this is detached and must not pin its replacement if (state.renderedTiles.get(index) === a) state.stickyTiles.add(index) } a.appendChild(img) diff --git a/app/src/client/virtualisation.ts b/app/src/client/virtualisation.ts index 79da592..46ebf4d 100644 --- a/app/src/client/virtualisation.ts +++ b/app/src/client/virtualisation.ts @@ -57,13 +57,8 @@ export function virtualize () { if (l.top > bottom) break neededTiles.add(l.index) } - // Sticky (already-loaded) tiles: keep them in the "needed" set so - // syncRendered never removes them and a scroll-back shows the cached image - // with no flicker. Bounded so a very large album can't grow unbounded DOM: - // 1. bump currently-visible sticky tiles to most-recently-used (set tail), - // 2. evict the oldest overflow that isn't on screen right now, - // 3. union whatever remains into neededTiles (all already rendered, so - // this only blocks removal - it never triggers a re-create). + // Sticky tiles (see state.stickyTiles): bump in-range ones to the tail, + // evict overflow from the head, keep the rest. Only ever blocks removal. for (const index of neededTiles) { if (state.stickyTiles.delete(index)) state.stickyTiles.add(index) } @@ -149,10 +144,7 @@ export function computeLayoutAndRender () { state.renderedTiles.clear() for (const [, el] of state.renderedHeaders) el.remove() state.renderedHeaders.clear() - // Tile positions/sizes have changed, so the old pinned elements are - // gone. Drop the sticky set and let tiles re-pin themselves as they reload - // for the new layout - otherwise the virtualize() below would rebuild every - // previously-seen tile at once. + // Otherwise virtualize() would rebuild every seen tile at once state.stickyTiles.clear() virtualize() @@ -175,8 +167,6 @@ export function loadVisibleTiles () { for (const a of state.renderedTiles.values()) { const img = a.firstElementChild if (!(img instanceof HTMLImageElement)) continue - // Fast-path: a finished load with no parked data-src has nothing to - // toggle. Matters now that sticky tiles keep this map large. if (img.complete && img.src && !img.dataset.src) continue const aTopInVp = containerTop + parseFloat(a.style.top || '0') const aHeight = parseFloat(a.style.height || '0')