Use Immich's orientation-aware dimensions instead of exif dimensions

This commit is contained in:
Alan Grainger
2026-07-27 09:53:05 +12:00
parent ceb49e14e3
commit fd42ab61da
2 changed files with 20 additions and 7 deletions
+6 -7
View File
@@ -58,13 +58,12 @@ const EXIF_RULES: FieldRule[] = [
},
{
flag: 'dimensions',
emit: (out, info) => {
if (info.exifImageWidth && info.exifImageHeight) {
out.width = info.exifImageWidth
out.height = info.exifImageHeight
if (info.orientation && ['5', '6', '7', '8'].includes(info.orientation)) {
[out.width, out.height] = [out.height, out.width]
}
emit: (out, _info, asset) => {
// Immich has already applied EXIF orientation to the asset-level
// dimensions; `exifImage*` holds the raw stored size.
if (asset.width && asset.height) {
out.width = asset.width
out.height = asset.height
}
}
},
+14
View File
@@ -55,9 +55,14 @@ describe('buildAssetMetadata', () => {
expect(meta.exif?.city).toBeUndefined()
})
// Immich applies EXIF orientation before storing asset.width / asset.height,
// so a rotated photo reports portrait dimensions there while the exifImage*
// pair stays landscape. We must report the former.
it('reports dimensions in display orientation', () => {
setConfig({ ipp: { showMetadata: { exif: { dimensions: true } } } })
const photo = asset()
photo.width = 3000
photo.height = 4000
photo.exifInfo!.exifImageWidth = 4000
photo.exifInfo!.exifImageHeight = 3000
photo.exifInfo!.orientation = '6'
@@ -68,6 +73,15 @@ describe('buildAssetMetadata', () => {
})
})
it('omits dimensions when the asset has none', () => {
setConfig({ ipp: { showMetadata: { exif: { dimensions: true } } } })
const photo = asset()
photo.exifInfo!.exifImageWidth = 4000
photo.exifInfo!.exifImageHeight = 3000
expect(buildAssetMetadata(photo, share()).exif).toBeUndefined()
})
it('returns description when a description surface is enabled', () => {
setConfig({ ipp: { showMetadata: { description: { sidebar: true } } } })
const meta = buildAssetMetadata(asset(), share())