Refactoring, added tests

###Fix # In light of submitting this as a pull request to the core of HA there have been some refactoring changes to comply with HA's style requirements #Sensor names now moved to strings file to allow for translations #Coordinator now properly handles multiple devices #Spelling of signal strength sensor corrected ###Feature #Tests added
2023-05-30 13:30:59 +01:00
parent c6f37493ca
commit 26f81c14bf
21 changed files with 4202 additions and 128 deletions
@@ -0,0 +1,237 @@
+"""Test Owlet config flow."""
+from __future__ import annotations
+
+from unittest.mock import patch
+
+from pyowletapi.exceptions import (
+    OwletCredentialsError,
+    OwletDevicesError,
+    OwletEmailError,
+    OwletPasswordError,
+)
+
+from homeassistant import config_entries
+from homeassistant.components.owlet.const import DOMAIN, POLLING_INTERVAL
+from homeassistant.config_entries import SOURCE_REAUTH, SOURCE_USER
+from homeassistant.const import CONF_PASSWORD, CONF_SCAN_INTERVAL
+from homeassistant.core import HomeAssistant
+from homeassistant.data_entry_flow import FlowResultType
+
+from . import async_init_integration
+from .const import AUTH_RETURN, CONF_INPUT
+
+
+async def test_form(hass: HomeAssistant) -> None:
+    """Test that the form is served with no input."""
+    # await async_init_integration(hass)
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_USER}
+    )
+
+    assert result["type"] == FlowResultType.FORM
+    assert result["step_id"] == "user"
+
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        return_value=AUTH_RETURN,
+    ), patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.validate_authentication"
+    ):
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"],
+            user_input=CONF_INPUT,
+        )
+        await hass.async_block_till_done()
+
+        assert result["type"] == FlowResultType.CREATE_ENTRY
+        assert result["title"] == "sample@gmail.com"
+        assert result["data"] == {
+            "region": "europe",
+            "username": "sample@gmail.com",
+            "api_token": "api_token",
+            "expiry": 100,
+            "refresh": "refresh_token",
+        }
+        assert result["options"] == {"scan_interval": POLLING_INTERVAL}
+
+
+async def test_flow_wrong_password(hass: HomeAssistant) -> None:
+    """Test incorrect login throwing error."""
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        side_effect=OwletPasswordError(),
+    ):
+        result = await hass.config_entries.flow.async_init(
+            DOMAIN,
+            context={"source": config_entries.SOURCE_USER},
+        )
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"],
+            user_input=CONF_INPUT,
+        )
+        assert result["type"] == FlowResultType.FORM
+        assert result["errors"] == {"base": "invalid_password"}
+
+
+async def test_flow_wrong_email(hass: HomeAssistant) -> None:
+    """Test incorrect login throwing error."""
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        side_effect=OwletEmailError(),
+    ):
+        result = await hass.config_entries.flow.async_init(
+            DOMAIN,
+            context={"source": config_entries.SOURCE_USER},
+        )
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"],
+            user_input=CONF_INPUT,
+        )
+        assert result["type"] == FlowResultType.FORM
+        assert result["errors"] == {"base": "invalid_email"}
+
+
+async def test_flow_credentials_error(hass: HomeAssistant) -> None:
+    """Test incorrect login throwing error."""
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        side_effect=OwletCredentialsError(),
+    ):
+        result = await hass.config_entries.flow.async_init(
+            DOMAIN,
+            context={"source": config_entries.SOURCE_USER},
+        )
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"],
+            user_input=CONF_INPUT,
+        )
+        assert result["type"] == FlowResultType.FORM
+        assert result["errors"] == {"base": "invalid_credentials"}
+
+
+async def test_flow_unknown_error(hass: HomeAssistant) -> None:
+    """Test unknown error throwing error."""
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        side_effect=Exception(),
+    ):
+        result = await hass.config_entries.flow.async_init(
+            DOMAIN,
+            context={"source": config_entries.SOURCE_USER},
+        )
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"],
+            user_input=CONF_INPUT,
+        )
+        assert result["type"] == FlowResultType.FORM
+        assert result["errors"] == {"base": "unknown"}
+
+
+async def test_flow_no_devices(hass: HomeAssistant) -> None:
+    """Test unknown error throwing error."""
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate"
+    ), patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.validate_authentication",
+        side_effect=OwletDevicesError(),
+    ):
+        result = await hass.config_entries.flow.async_init(
+            DOMAIN,
+            context={"source": config_entries.SOURCE_USER},
+        )
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"],
+            user_input=CONF_INPUT,
+        )
+        assert result["type"] == FlowResultType.FORM
+        assert result["errors"] == {"base": "no_devices"}
+
+
+async def test_reauth_success(hass: HomeAssistant) -> None:
+    """Test reauth form."""
+
+    entry = await async_init_integration(hass, skip_setup=True)
+
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_REAUTH, "entry_id": entry.entry_id}
+    )
+
+    assert result["type"] == FlowResultType.FORM
+    assert result["step_id"] == "reauth_confirm"
+
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        return_value=AUTH_RETURN,
+    ):
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"],
+            user_input={CONF_PASSWORD: "sample"},
+        )
+        await hass.async_block_till_done()
+
+        assert result["type"] == FlowResultType.ABORT
+        assert result["reason"] == "reauth_successful"
+
+        await hass.config_entries.async_unload(entry.entry_id)
+
+
+async def test_reauth_invalid_password(hass: HomeAssistant) -> None:
+    """Test reauth with invalid password errir."""
+    entry = await async_init_integration(hass, skip_setup=True)
+
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_REAUTH, "entry_id": entry.entry_id}
+    )
+
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        side_effect=OwletPasswordError(),
+    ):
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"], user_input={CONF_PASSWORD: "sample"}
+        )
+
+        assert result["type"] == FlowResultType.FORM
+        assert result["step_id"] == "reauth_confirm"
+        assert result["errors"] == {"base": "invalid_password"}
+
+
+async def test_reauth_unknown_error(hass: HomeAssistant) -> None:
+    """Test reauthing with an unknown error."""
+
+    entry = await async_init_integration(hass, skip_setup=True)
+
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_REAUTH, "entry_id": entry.entry_id}
+    )
+
+    with patch(
+        "homeassistant.components.owlet.config_flow.OwletAPI.authenticate",
+        side_effect=Exception(),
+    ):
+        result = await hass.config_entries.flow.async_configure(
+            result["flow_id"], user_input={CONF_PASSWORD: "sample"}
+        )
+
+        assert result["type"] == FlowResultType.FORM
+        assert result["step_id"] == "reauth_confirm"
+
+
+async def test_options_flow(hass: HomeAssistant) -> None:
+    """Test that the form is served with no input."""
+    entry = await async_init_integration(hass, skip_setup=True)
+
+    result = await hass.config_entries.options.async_init(entry.entry_id)
+
+    assert result["type"] == FlowResultType.FORM
+    assert result["step_id"] == "init"
+
+    result = await hass.config_entries.options.async_configure(
+        result["flow_id"],
+        user_input={CONF_SCAN_INTERVAL: 10},
+    )
+    await hass.async_block_till_done()
+
+    assert result["type"] == FlowResultType.CREATE_ENTRY
+    assert result["title"] == ""
+    assert result["data"] == {CONF_SCAN_INTERVAL: 10}