Fixes based on code reviews
This commit is contained in:
		
							parent
							
								
									d86ae69961
								
							
						
					
					
						commit
						05f8850acf
					
				@ -120,10 +120,7 @@ void Alarm::OnButtonEvent(lv_obj_t* obj, lv_event_t event) {
 | 
			
		||||
      return;
 | 
			
		||||
    }
 | 
			
		||||
    if (obj == btnMessage) {
 | 
			
		||||
      lv_obj_del(txtMessage);
 | 
			
		||||
      lv_obj_del(btnMessage);
 | 
			
		||||
      txtMessage = nullptr;
 | 
			
		||||
      btnMessage = nullptr;
 | 
			
		||||
      HideInfo();
 | 
			
		||||
      return;
 | 
			
		||||
    }
 | 
			
		||||
    // If any other button was pressed, disable the alarm
 | 
			
		||||
@ -176,10 +173,7 @@ void Alarm::OnButtonEvent(lv_obj_t* obj, lv_event_t event) {
 | 
			
		||||
 | 
			
		||||
bool Alarm::OnButtonPushed() {
 | 
			
		||||
  if (txtMessage != nullptr && btnMessage != nullptr) {
 | 
			
		||||
    lv_obj_del(txtMessage);
 | 
			
		||||
    lv_obj_del(btnMessage);
 | 
			
		||||
    txtMessage = nullptr;
 | 
			
		||||
    btnMessage = nullptr;
 | 
			
		||||
    HideInfo();
 | 
			
		||||
    return true;
 | 
			
		||||
  }
 | 
			
		||||
  return false;
 | 
			
		||||
@ -235,6 +229,12 @@ void Alarm::ShowInfo() {
 | 
			
		||||
  }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void Alarm::HideInfo() {
 | 
			
		||||
  lv_obj_del(btnMessage);
 | 
			
		||||
  txtMessage = nullptr;
 | 
			
		||||
  btnMessage = nullptr;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void Alarm::SetRecurButtonState() {
 | 
			
		||||
  using Pinetime::Controllers::AlarmController;
 | 
			
		||||
  switch (alarmController.Recurrence()) {
 | 
			
		||||
 | 
			
		||||
@ -47,6 +47,7 @@ namespace Pinetime {
 | 
			
		||||
        void SetRecurButtonState();
 | 
			
		||||
        void SetAlarm();
 | 
			
		||||
        void ShowInfo();
 | 
			
		||||
        void HideInfo();
 | 
			
		||||
        void ToggleRecurrence();
 | 
			
		||||
        void UpdateAlarmTime();
 | 
			
		||||
      };
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user