using strings instead of symbols
This commit is contained in:
parent
a764632dd2
commit
7f7a7f957c
|
@ -165,7 +165,7 @@ Make sure, that you push tags to remote repo via 'git push --tags'"
|
|||
print_in_same_line(" ")
|
||||
end
|
||||
|
||||
# Fetch event for all issues and add them to :events
|
||||
# Fetch event for all issues and add them to events
|
||||
# @param [Array] issues
|
||||
# @return [Void]
|
||||
def fetch_events_async(issues)
|
||||
|
|
|
@ -49,12 +49,12 @@ module GitHubChangelogGenerator
|
|||
# Fill :actual_date parameter of specified issue by closed date of the commit, if it was closed by commit.
|
||||
# @param [Hash] issue
|
||||
def find_closed_date_by_commit(issue)
|
||||
unless issue[:events].nil?
|
||||
unless issue['events'].nil?
|
||||
# if it's PR -> then find "merged event", in case of usual issue -> fond closed date
|
||||
compare_string = issue[:merged_at].nil? ? "closed" : "merged"
|
||||
compare_string = issue['merged_at'].nil? ? "closed" : "merged"
|
||||
# reverse! - to find latest closed event. (event goes in date order)
|
||||
issue[:events].reverse!.each do |event|
|
||||
if event[:event].eql? compare_string
|
||||
issue['events'].reverse!.each do |event|
|
||||
if event['event'].eql? compare_string
|
||||
set_date_from_event(event, issue)
|
||||
break
|
||||
end
|
||||
|
@ -68,16 +68,16 @@ module GitHubChangelogGenerator
|
|||
# @param [Hash] event
|
||||
# @param [Hash] issue
|
||||
def set_date_from_event(event, issue)
|
||||
if event[:commit_id].nil?
|
||||
issue[:actual_date] = issue[:closed_at]
|
||||
if event['commit_id'].nil?
|
||||
issue['actual_date'] = issue['closed_at']
|
||||
else
|
||||
begin
|
||||
commit = @fetcher.fetch_commit(event)
|
||||
issue[:actual_date] = commit[:commit][:author][:date]
|
||||
# issue[:actual_date] = commit[:author][:date]
|
||||
issue['actual_date'] = commit['commit']['author']['date']
|
||||
# issue['actual_date'] = commit['author']['date']
|
||||
rescue
|
||||
puts "Warning: Can't fetch commit #{event[:commit_id]}. It is probably referenced from another repo."
|
||||
issue[:actual_date] = issue[:closed_at]
|
||||
puts "Warning: Can't fetch commit #{event['commit_id']}. It is probably referenced from another repo."
|
||||
issue['actual_date'] = issue['closed_at']
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
|
@ -164,7 +164,7 @@ Make sure, that you push tags to remote repo via 'git push --tags'".yellow
|
|||
pull_requests
|
||||
end
|
||||
|
||||
# Fetch event for all issues and add them to :events
|
||||
# Fetch event for all issues and add them to 'events'
|
||||
#
|
||||
# @param [Array] issues
|
||||
# @return [Void]
|
||||
|
@ -175,11 +175,11 @@ Make sure, that you push tags to remote repo via 'git push --tags'".yellow
|
|||
issues.each_slice(MAX_THREAD_NUMBER) do |issues_slice|
|
||||
issues_slice.each do |issue|
|
||||
threads << Thread.new do
|
||||
issue[:events] = []
|
||||
issue['events'] = []
|
||||
iterate_pages(@client, 'issue_events', issue['number'], {}) do |new_event|
|
||||
issue[:events].concat(new_event)
|
||||
issue['events'].concat(new_event)
|
||||
end
|
||||
issue[:events] = issue[:events].map{|h| h.to_hash.stringify_keys_deep! }
|
||||
issue['events'] = issue['events'].map{|h| h.to_hash.stringify_keys_deep! }
|
||||
print_in_same_line("Fetching events for issues and PR: #{i + 1}/#{issues.count}")
|
||||
i += 1
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue
Block a user