Commit Graph

110 Commits

Author SHA1 Message Date
Florian Thomas
64f4cd07c9 filter tags correctly when since_tag is set to most recent tag (#566)
* filter tags correctly when `since_tag` is set to most recent tag
Before this fix [`filtered_tags`](https://github.com/skywinder/github-changelog-generator/blob/master/lib/github_changelog_generator/generator/generator_generation.rb#L132)
was empty which caused a fallback to the last tag in the sorted_tags array (which is the oldest tag).
There for no issues and PRs were filtered in that case.

fixes #555
fixes #304
2017-10-05 23:15:06 +02:00
Umberto Nicoletti
1f68ef8bad Use closed_at and merged_at when filtering issues/prs (#504)
* use closed_at and merged_at when filtering issues/prs
* document use of closed_at and merged_at
2017-09-30 20:45:31 +02:00
Olle Jonsson
9662c935c3 RuboCop 0.50.0; lints 2017-09-18 21:14:47 +02:00
Olle Jonsson
b94fb7f839 Remove all old credit lines in the output then add a new one (#526)
* Fixes #507 - Removes old credit lines in log so that there are no duplicates

* Added missing newline at end of file

* Replaced single-quoted empty string with double quotes
2017-09-10 11:56:11 +02:00
Olle Jonsson
519cd5b136 Tiny whitespace detail [ci skip] 2017-09-10 11:55:49 +02:00
Jerome Lacoste
d2a8dc3977 warn_if_nonmatching_regex should display proper help message when used with exclude-tags-regex (#551) 2017-08-09 10:06:32 +02:00
Hunter Haugen
a287bd872b
Rebase, pass rubocop, remove between-tags references
This is a rebase and resubmission of #453
2017-07-27 15:51:49 -07:00
Tom Duffield
5932cb730b
Fix parameter type in doc for generator
Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:39:28 -07:00
Tom Duffield
726f8f79fb
Don't show untagged issues when desired
When `add_issues_wo_labels` is false, do not include issues that do not
have any labels in the CHANGELOG (per documentation).

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:39:22 -07:00
Tom Duffield
b91609283e
Don't show untagged PRs
As far as I can tell, `add_pr_wo_labels` wasn't actually
implemented. Implementing this per the documentation.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:55 -07:00
Tom Duffield
174baec266
Use first SHA for last tag
Rather than having the last tag be an empty husk, generate a full
changelog link using the first sha from the repository.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:49 -07:00
Tom Duffield
ee5a507f76
Filter excluded tags within the section map builder
Because we need might need excluded tags to build compare links, the
section map generator needs to have access to those tags. But, we don't
want excluded tags to have section headers. So instead, we'll create
another copy of the list that doesn't have tags excluded.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:38 -07:00
Tom Duffield
66177c58e3
DRY up the tests and address Rubocop feedback
Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:32 -07:00
Tom Duffield
d6c26ef4a9
Generate mapping that will match expectations
This change neccesitated changing the behavior or the
`filter_since_tag`. Since we want our compare links to include the since
tag, we need to keep that tag in the filtered list. Instead, we detect
that the tag is the since tag and filter it out. This will prevent the
since_tag header from being duplicated when pulling from a base.

The same goes for the first tag listed in between_tags. We don't want an
empty section header for this.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:26 -07:00
Ian Roberts
4c26bbd7c0 Add newline after version (#548)
Add newline after version name and Full Changelog link
2017-07-19 15:26:40 +02:00
Stanislav Kozlovski
e5f0a55304 Merge branch 'master' into master 2017-06-28 21:33:28 +03:00
Lucas Huang
b21e7eaaf7 Update generator_generation.rb (#542)
Fix the syntax so `credit_line` is recognizable as a variable. #541
2017-06-28 16:55:42 +02:00
Lucas Huang
d0e7593e98 Fix the syntax ambiguity on credit-line-bug (#537)
* fix a syntax ambiguity
2017-06-27 19:45:57 +02:00
Lucas Huang
fb7e21f9f8 Credit line bug (#535)
* Fix a bug that generates multiple credit lines
2017-06-27 07:45:59 +02:00
Enether
5bbeb93869 Replaced single-quoted empty string with double quotes 2017-06-03 18:39:48 +03:00
Enether
3d27670053 Added missing newline at end of file 2017-06-03 18:26:15 +03:00
Enether
2cc15f7be0 Fixes #507 - Removes old credit lines in log so that there are no duplicates 2017-06-03 18:22:23 +03:00
Olle Jonsson
6ad5aa106d Bug: require ActiveSupport core_ext blank (#520) 2017-05-25 14:07:34 +02:00
Lucas Huang
e9ee9556ce remove --between_tags option (#501) 2017-05-25 00:29:31 +02:00
Olle Jonsson
874c23c64f Chore: Rubocop 0.49.0 (#516)
* Rubocoping
2017-05-25 00:11:02 +02:00
Thorsten
d551c3a198 Fixed issue #442 - broken issue-line-labels in log. (#443) 2016-11-05 08:44:28 +01:00
Thorsten Eckel
014da21bf5 Fixed bug: Last entries get lost. 2016-11-04 20:18:09 +01:00
Thorsten Eckel
83dcb3cdf9 Fixed issue #304 - entries of previous tags are included. 2016-11-04 19:51:58 +01:00
aih
1fd341d9bf Add option to show selected labels in the issue line: --issue-line-labels 2016-10-26 09:50:54 -07:00
Olle Jonsson
8632bcf254 On GitHub MAX_THREAD_NUMBER is 25 2016-10-06 00:23:11 +02:00
Olle Jonsson
5ae7027425 Fix: Turn Sawyer method into String-keyed hash access (#429) 2016-10-01 19:46:52 +02:00
Olle Jonsson
bd024f6b63 Style: Use attr_reader for options
- prefer parentheses
2016-09-29 23:09:05 +02:00
Olle Jonsson
e23f2ff7e1 Typo: variable rename 2016-09-29 23:09:05 +02:00
Olle Jonsson
ba825488bd Typo, renamed var 2016-09-29 23:09:05 +02:00
Olle Jonsson
d8b34169a3 Linting 2016-09-29 23:09:04 +02:00
Olle Jonsson
1177f09ca5 Drop Hashie dependency 2016-09-29 23:09:04 +02:00
Andrew Waage
71c337cdcf fixed a bug in fetching tags 2016-09-29 23:09:04 +02:00
Andrew Waage
42c377d285 fixed one bug in filtering excluded tags 2016-09-29 23:09:04 +02:00
Andrew Waage
b79d672424 fixed 1 bug to work with octokit api 2016-09-29 23:09:04 +02:00
Andrew Waage
dbcc1cb98d merged in the tag fixes 2016-09-29 23:09:04 +02:00
Andrew Waage
ef9867c122 fixing rubocop and removing original fetcher 2016-09-29 23:09:04 +02:00
Andrew Waage
0e948fb125 max thread 1 2016-09-29 23:09:04 +02:00
Andrew Waage
2cafff7abb changing max threads to 4 2016-09-29 23:09:04 +02:00
Andrew Waage
10cf2a0f04 minor clean up 2016-09-29 23:09:04 +02:00
Andrew Waage
a178822c83 fixed some handling of hashes 2016-09-29 23:09:04 +02:00
Andrew Waage
7f7a7f957c using strings instead of symbols 2016-09-29 23:09:04 +02:00
Andrew Waage
2347cc4220 added specs for the new octo_fetcher. Also had to refactor a bit to deal with hashes and arrays instead of objects 2016-09-29 23:09:04 +02:00
Andrew Waage
d7b88a521a changed the format of how dates are fetched from commit 2016-09-29 23:09:03 +02:00
Andrew Waage
53377388ee clean up 2016-09-29 23:09:03 +02:00
Andrew Waage
a8e6c5406e created a new fetcher with octokit. functionality should remain same 2016-09-29 23:09:03 +02:00