Commit Graph

1467 Commits

Author SHA1 Message Date
Olle Jonsson
3f8fb60af3 OctoFetcher: Use defaults for request_options (#571)
* OctoFetcher: rely on default args

  - in iterate_pages

* OctoFetcher: extract options method
2017-10-10 23:48:00 +02:00
Olle Jonsson
23b341f715 OctoFetcher: extract methods (#570)
* OctoFetcher: extract methods

* OctoFetcher: extract github_options smethod

* OctoFetcher: Document exception, name parameters

  - more communicative names

* OctoFetcher#fetch_github_token: simplify

  - using ActiveSupport

* OctoFetcher#init_cache: fewer statements

* OctoFetcher: inline calls, name parameters

* OctoFetcher: name parameters, inline local
2017-10-10 23:05:10 +02:00
Olle Jonsson
630b8cee88 OctoFetcher: extract method fail_with_message (#569) 2017-10-10 21:42:29 +02:00
Olle Jonsson
74fdc2026a OctoFetcher: drop unused number_of_pages feature (#568) 2017-10-10 21:22:17 +02:00
Tim Meusel
21ec2db39b Add breaking-changes section to changelog (#530)
* add breaking-changes section to changelog

* Clean up parse_by_sections

* Thank you bastelfreak and ekohl!
2017-10-10 20:27:23 +02:00
Olle Jonsson
d1e09f6964 Travis: Do not test on jruby-head (#567) 2017-10-10 20:11:36 +02:00
Olle Jonsson
b36d85eb53 Drop Project-and-Username-finding code (#451)
* Remove Project-and-Username finding code and usages

* Remove "github_remote" option, now unused

* Update README: Usage has changed
2017-10-10 19:53:21 +02:00
Ben Holden-Crowther
1658b41dff Update license date to a range (#553)
* Update license date to a range containing 2017
2017-10-05 23:38:23 +02:00
Florian Thomas
64f4cd07c9 filter tags correctly when since_tag is set to most recent tag (#566)
* filter tags correctly when `since_tag` is set to most recent tag
Before this fix [`filtered_tags`](https://github.com/skywinder/github-changelog-generator/blob/master/lib/github_changelog_generator/generator/generator_generation.rb#L132)
was empty which caused a fallback to the last tag in the sorted_tags array (which is the oldest tag).
There for no issues and PRs were filtered in that case.

fixes #555
fixes #304
2017-10-05 23:15:06 +02:00
Olle Jonsson
7cbe41555a Drop unused Rake task (#564) 2017-10-04 09:06:49 +02:00
Olle Jonsson
dd956b7b95 CHANGELOG for v1.15.0.pre.alpha 2017-10-01 15:47:16 +02:00
Olle Jonsson
07a665d800 v1.15.0-alpha 2017-10-01 15:28:09 +02:00
Umberto Nicoletti
1f68ef8bad Use closed_at and merged_at when filtering issues/prs (#504)
* use closed_at and merged_at when filtering issues/prs
* document use of closed_at and merged_at
2017-09-30 20:45:31 +02:00
Olle Jonsson
efa960ce1c Travis: update CI matrix (#561)
- Ruby 2.2.8, 2.3.5 and 2.4.2
2017-09-18 22:04:22 +02:00
Olle Jonsson
ba086bbf07 Travis: Configure cache: bundler: true (#563) 2017-09-18 22:02:18 +02:00
Olle Jonsson
ada39f9735 Merge pull request #562 from olleolleolle/fix/use-jruby-9-1-13-0
Travis: use JRuby 9.1.13.0; don't redo rvm's job
2017-09-18 21:33:46 +02:00
Olle Jonsson
bf2436037f Travis: add fast_finish: true to matrix 2017-09-18 21:14:47 +02:00
Olle Jonsson
9662c935c3 RuboCop 0.50.0; lints 2017-09-18 21:14:47 +02:00
Olle Jonsson
7f12a55ae8 Travis: use JRuby 9.1.13.0; don't redo rvm's job 2017-09-18 21:14:10 +02:00
Olle Jonsson
b94fb7f839 Remove all old credit lines in the output then add a new one (#526)
* Fixes #507 - Removes old credit lines in log so that there are no duplicates

* Added missing newline at end of file

* Replaced single-quoted empty string with double quotes
2017-09-10 11:56:11 +02:00
Olle Jonsson
519cd5b136 Tiny whitespace detail [ci skip] 2017-09-10 11:55:49 +02:00
Jerome Lacoste
d2a8dc3977 warn_if_nonmatching_regex should display proper help message when used with exclude-tags-regex (#551) 2017-08-09 10:06:32 +02:00
Lucas Huang
33f89614d4 Delete circle.yml (#532) 2017-07-30 17:48:27 +02:00
Olle Jonsson
c805da1886 Merge pull request #550 from hunner/chef-adjust-tag-section-mapping
Fix section mapping, hiding untagged PRs, and hiding untagged issues
2017-07-30 17:44:46 +02:00
Hunter Haugen
a287bd872b
Rebase, pass rubocop, remove between-tags references
This is a rebase and resubmission of #453
2017-07-27 15:51:49 -07:00
Thom May
b1121cb1ee
Use our default labels across the board
Signed-off-by: Thom May <thom@chef.io>
2017-07-27 10:44:00 -07:00
Tom Duffield
0ca7371306
Add tests for label filtering
Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:41:52 -07:00
Tom Duffield
ce63f648ac
include default options in tags tests
Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:39:38 -07:00
Tom Duffield
5932cb730b
Fix parameter type in doc for generator
Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:39:28 -07:00
Tom Duffield
726f8f79fb
Don't show untagged issues when desired
When `add_issues_wo_labels` is false, do not include issues that do not
have any labels in the CHANGELOG (per documentation).

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:39:22 -07:00
Tom Duffield
b91609283e
Don't show untagged PRs
As far as I can tell, `add_pr_wo_labels` wasn't actually
implemented. Implementing this per the documentation.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:55 -07:00
Tom Duffield
174baec266
Use first SHA for last tag
Rather than having the last tag be an empty husk, generate a full
changelog link using the first sha from the repository.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:49 -07:00
Tom Duffield
f57b4c283d
Rename tag section mapping test
Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:44 -07:00
Tom Duffield
ee5a507f76
Filter excluded tags within the section map builder
Because we need might need excluded tags to build compare links, the
section map generator needs to have access to those tags. But, we don't
want excluded tags to have section headers. So instead, we'll create
another copy of the list that doesn't have tags excluded.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:38 -07:00
Tom Duffield
66177c58e3
DRY up the tests and address Rubocop feedback
Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:32 -07:00
Tom Duffield
d6c26ef4a9
Generate mapping that will match expectations
This change neccesitated changing the behavior or the
`filter_since_tag`. Since we want our compare links to include the since
tag, we need to keep that tag in the filtered list. Instead, we detect
that the tag is the since tag and filter it out. This will prevent the
since_tag header from being duplicated when pulling from a base.

The same goes for the first tag listed in between_tags. We don't want an
empty section header for this.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:37:26 -07:00
Tom Duffield
c718930fb1
Add initial tests for tag_section_mapping
Before we do anything, let's get a solid expectation of what we want our
section headers to look like.

Signed-off-by: Tom Duffield <tom@chef.io>
2017-07-27 10:36:11 -07:00
Ian Roberts
4c26bbd7c0 Add newline after version (#548)
Add newline after version name and Full Changelog link
2017-07-19 15:26:40 +02:00
Olle Jonsson
8dd91f6f10 README: repair broken Markdown [ci skip]
- and be more clear about the skywinder/changelog_test repo
2017-07-16 17:52:47 +02:00
Stanislav Kozlovski
87f65faffc Merge branch 'master' into master 2017-07-03 09:45:14 +03:00
Stanislav Kozlovski
e5f0a55304 Merge branch 'master' into master 2017-06-28 21:33:28 +03:00
Lucas Huang
b21e7eaaf7 Update generator_generation.rb (#542)
Fix the syntax so `credit_line` is recognizable as a variable. #541
2017-06-28 16:55:42 +02:00
Olle Jonsson
ee4c72c7aa Revert "AppVeyor: drop init line, add .gitattributes (#539)"
This reverts commit e37ce502ea.
2017-06-27 21:14:37 +02:00
Olle Jonsson
e37ce502ea AppVeyor: drop init line, add .gitattributes (#539) 2017-06-27 21:08:10 +02:00
Olle Jonsson
e77202163c AppVeyor: Windows configuration to pass RuboCop (#538)
* AppVeyor: Windows configuration to pass RuboCop
* README: AppVeyor build badge
* AppVeyor: GitHubPullRequest notification
2017-06-27 20:40:55 +02:00
Lucas Huang
d0e7593e98 Fix the syntax ambiguity on credit-line-bug (#537)
* fix a syntax ambiguity
2017-06-27 19:45:57 +02:00
Lucas Huang
fb7e21f9f8 Credit line bug (#535)
* Fix a bug that generates multiple credit lines
2017-06-27 07:45:59 +02:00
Lucas Huang
3798d0637c Update README.md (#534) 2017-06-25 10:48:55 +02:00
Lucas Huang
f643b3e44e Update README.md (#531)
A better README.md file
2017-06-25 08:41:12 +02:00
Olle Jonsson
0be0631320 Travis: jruby-9.1.12.0 2017-06-19 09:16:23 +02:00