Remove buffering for single downloads #94
This commit is contained in:
@@ -96,7 +96,9 @@ export async function assetBuffer (req: IncomingShareRequest, res: Response, ass
|
||||
return
|
||||
}
|
||||
|
||||
if (attachment && asset.originalFileName) {
|
||||
if (attachment) {
|
||||
res.setHeader('X-Accel-Buffering', 'no')
|
||||
if (asset.originalFileName) {
|
||||
// Playback downloads serve Immich's transcode, so the filename extension
|
||||
// must follow the response's content-type, not the original file's.
|
||||
const playbackMime = useVideoPlayback
|
||||
@@ -105,6 +107,7 @@ export async function assetBuffer (req: IncomingShareRequest, res: Response, ass
|
||||
const filename = encodeURI(getFilename(asset, servedSize, playbackMime))
|
||||
res.setHeader('Content-Disposition', `attachment; filename*=UTF-8''${filename}`)
|
||||
}
|
||||
}
|
||||
headerList.forEach(header => {
|
||||
const value = data.headers.get(header)
|
||||
if (value) res.setHeader(header, value)
|
||||
|
||||
@@ -118,6 +118,7 @@ describe('assetBuffer streaming', () => {
|
||||
expect(res.headers['content-type']).toBe('image/jpeg')
|
||||
expect(res.headers['content-length']).toBe(String(4 * CHUNK))
|
||||
expect(res.headers['content-disposition']).toContain('a1.jpg')
|
||||
expect(res.headers['x-accel-buffering']).toBe('no')
|
||||
})
|
||||
|
||||
it('applies backpressure so upstream is read no faster than the visitor drains it', async () => {
|
||||
|
||||
Reference in New Issue
Block a user